Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-ng-packagr): add tsickle as optional peer dep #16178

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix(@angular-devkit/build-ng-packagr): add tsickle as optional peer dep #16178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/angular_devkit/build_ng_packagr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,19 @@
"rxjs": "6.5.3"
},
"peerDependencies": {
"ng-packagr": "^9.0.0-rc.0"
"ng-packagr": "^9.0.0-rc.0",
"tsickle": "~0.37.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that the fix for this was the include the dependency in the packageGroup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was the original idea, but then Charles brough the optional peer dep up that both ensures it is updated, and ensures that if it is present on install (outside of update) it should be the right version. Do you think there are problems with this approach?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, I was just curios to know why the change :)

},
"devDependencies": {
"@angular/compiler": "9.0.0-rc.1",
"@angular/compiler-cli": "9.0.0-rc.1",
"@angular-devkit/core": "0.0.0",
"ng-packagr": "~9.0.0-rc.0",
"tslib": "^1.10.0"
},
"peerDependenciesMeta": {
"tsickle": {
"optional": true
}
}
}
}