fix(compiler): limit the number of chained instructions #57069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
action: review
crisbeto
approved these changes
Jul 22, 2024
JoostK
added
action: merge
Some Angular template instructions that follow each other may be chained together in a single expressions statement, containing a deeply nested AST of call expressions. The number of chained instructions wasn't previously limited, so this could result in very deep ASTs that cause stack overflow errors during TypeScript emit. This commit introduces a limit to the number of chained instructions to avoid these problems. Closes angular#57066
JoostK
force-pushed
the
compiler/limit_chaining_depth
branch
from
1bfeaa7
to
a5d053d
Compare
crisbeto
approved these changes
Jul 22, 2024
|
I've just kicked off a presubmit. |
|
This PR was merged into the repository by commit 08c5977. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 22, 2024
Some Angular template instructions that follow each other may be chained together in a single expressions statement, containing a deeply nested AST of call expressions. The number of chained instructions wasn't previously limited, so this could result in very deep ASTs that cause stack overflow errors during TypeScript emit. This commit introduces a limit to the number of chained instructions to avoid these problems. Closes #57066 PR Close #57069
This was referenced Jul 25, 2024
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
Some Angular template instructions that follow each other may be chained together in a single expressions statement, containing a deeply nested AST of call expressions. The number of chained instructions wasn't previously limited, so this could result in very deep ASTs that cause stack overflow errors during TypeScript emit. This commit introduces a limit to the number of chained instructions to avoid these problems. Closes angular#57066 PR Close angular#57069
ShahriarMalik
pushed a commit
to ShahriarMalik/angular
that referenced
this pull request
Jul 30, 2024
Some Angular template instructions that follow each other may be chained together in a single expressions statement, containing a deeply nested AST of call expressions. The number of chained instructions wasn't previously limited, so this could result in very deep ASTs that cause stack overflow errors during TypeScript emit. This commit introduces a limit to the number of chained instructions to avoid these problems. Closes angular#57066 PR Close angular#57069
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Angular template instructions that follow each other may be chained together in a single expressions statement, containing a deeply nested AST of call expressions. The number of chained instructions wasn't previously limited, so this could result in very deep ASTs that cause stack overflow errors during TypeScript emit.
This commit introduces a limit to the number of chained instructions to avoid these problems.
Closes #57066