Commits on Jul 22, 2022

1. fix(material-experimental/mdc-chips): don't use button element if chi… …

   …p row isn't editable
   
   Currently we always use a `button` element inside the `mat-chip-row` which can be confusing for users if the row isn't editable, because the button won't do anything.
   
   These changes switch to using a `span` whose `role` we toggle based on whether it's editable.
   
   The change ended up trickier than expected, because:
   1. The focus behavior of the `span` is slightly different from the button we had before.
   2. The focus restoration after an edit is finished is currently working by accident. When editing starts, we set `isInteractive = false` on the primary action which clears its `tabindex`. When editing is finished, we reset the flag, but change detection hasn't had the chance to run so the element won't actually have a `tabindex` at the moment when we try to restore focus. It worked by accident because a `button` is still focusable even without a `tabindex`.
   
   An alternative approach I was testing out was to swap between a `span` and `button` element based on the `editable` input, but that didn't work, because we have a `ViewChild` query for the primary action which wasn't being updated by the framework.

   

   crisbeto committed Jul 22, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 54ef8a0
   • Browse repository at this point

   Copy the full SHA

   54ef8a0 View commit details

   Browse the repository at this point in the history