-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/tooltip): animation not cancelled when mouseleave goes through tooltip #25740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough tooltip We ignore `mouseleave` events that go into the tooltip which meant that some animations weren't being cancelled correctly after the fix in angular#25699. These changes resolve the issue by skipping all animations if the tooltip isn't fully shown yet. Fixes angular#24614.
crisbeto
added
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
labels
Oct 2, 2022
crisbeto
requested review from
devversion,
josephperrott and
andrewseguin
as code owners
October 2, 2022 08:34
wagnermaciel
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
crisbeto
added a commit
that referenced
this pull request
Oct 3, 2022
…hrough tooltip (#25740) We ignore `mouseleave` events that go into the tooltip which meant that some animations weren't being cancelled correctly after the fix in #25699. These changes resolve the issue by skipping all animations if the tooltip isn't fully shown yet. Fixes #24614. (cherry picked from commit 6526277)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 5, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.3/14.2.4) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.3/14.2.4) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.4`](https://github.com/angular/components/releases/tag/14.2.4) [Compare Source](angular/components@14.2.3...14.2.4) ##### 14.2.4 "calcium-coconut" (2022-10-05) ##### material | Commit | Description | | -- | -- | | [![fix - 9909f2a33](https://img.shields.io/badge/9909f2a33-fix-green)](https://github.com/angular/components/commit/9909f2a33844c8dfe0a481f3aa0895b8dbb3be9a) | **tooltip:** animation not cancelled when mouseleave goes through tooltip ([#​25740](angular/components#25740)) | ##### Special Thanks Joey Perrott, Kristiyan Kostadinov and Titos Chaniotakis </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1575 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore
mouseleave
events that go into the tooltip which meant that some animations weren't being cancelled correctly after the fix in #25699. These changes resolve the issue by skipping all animations if the tooltip isn't fully shown yet.Fixes #24614.