Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/drag-drop): constrainPosition now working well with boundary #27730

Merged

Conversation

mj3052
Copy link
Contributor

@mj3052 mj3052 commented Aug 30, 2023

Initial attempt at a fix for #25154

@mj3052 mj3052 requested a review from crisbeto as a code owner August 30, 2023 13:14
@google-cla
Copy link

google-cla bot commented Aug 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

src/dev-app/drag-drop/drag-drop-demo.ts Outdated Show resolved Hide resolved
src/cdk/drag-drop/drag-ref.ts Show resolved Hide resolved
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the test. It looks like there are a couple of lint failures as well.

src/cdk/drag-drop/drag-ref.ts Show resolved Hide resolved
@mj3052 mj3052 force-pushed the 25154/drag-drop-constrain-position-with-boundary branch from aac2232 to 26a87c2 Compare August 31, 2023 08:35
@mj3052 mj3052 force-pushed the 25154/drag-drop-constrain-position-with-boundary branch from 26a87c2 to 487d2f2 Compare August 31, 2023 08:38
@mj3052 mj3052 requested a review from crisbeto August 31, 2023 10:48
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 31, 2023
@crisbeto crisbeto self-assigned this Aug 31, 2023
@mj3052
Copy link
Contributor Author

mj3052 commented Aug 31, 2023

@crisbeto Do you need anything else from me?

Should I squash the commits and make sure the commit message follows the guidelines, or how does that happen?

@crisbeto
Copy link
Member

It's okay, I'll squash the commits when I merge it in.

@crisbeto crisbeto merged commit aa1d01d into angular:main Aug 31, 2023
17 checks passed
crisbeto pushed a commit that referenced this pull request Aug 31, 2023
…27730)

* fix(cdk/drag-drop): constrainPosition now working well with boundary

* Add tests for x/y lock while using constrainPosition

(cherry picked from commit aa1d01d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2023
@mj3052 mj3052 deleted the 25154/drag-drop-constrain-position-with-boundary branch January 7, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants