-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: configure vscode bazel integration #29279
Conversation
"editor.rulers": [100], | ||
"bazel.buildifierExecutable": "node_modules/.bin/buildifier", | ||
"bazel.buildifierFixOnFormat": true, | ||
"bazel.executable": "node_modules/.bin/bazel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might break on Windows, but I'm not sure. Worth giving a shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might work, the things in node_modules/.bin appear to be nodejs executables that delegate to the appropriate native binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Windows, the files are often .cmd
. E.g. node_modules/.bin/bazel.cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that they would make a nodejs program to delegate to different native implementations and then not give it the same name across environments, kind of defeats the point I would think... 🤷♂️
(cherry picked from commit c7ced66)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.