Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: configure vscode bazel integration #29279

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 18, 2024
@mmalerba mmalerba requested a review from a team as a code owner June 18, 2024 22:44
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 18, 2024
"editor.rulers": [100],
"bazel.buildifierExecutable": "node_modules/.bin/buildifier",
"bazel.buildifierFixOnFormat": true,
"bazel.executable": "node_modules/.bin/bazel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break on Windows, but I'm not sure. Worth giving a shot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might work, the things in node_modules/.bin appear to be nodejs executables that delegate to the appropriate native binary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the files are often .cmd. E.g. node_modules/.bin/bazel.cmd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that they would make a nodejs program to delegate to different native implementations and then not give it the same name across environments, kind of defeats the point I would think... 🤷‍♂️

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2024
@mmalerba mmalerba merged commit c7ced66 into angular:main Jun 19, 2024
25 of 27 checks passed
mmalerba added a commit that referenced this pull request Jun 19, 2024
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants