Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/menu): animation issue when same menu is used for multiple nested triggers #29280

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

crisbeto
Copy link
Member

If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu.

These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.

…le nested triggers

If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu.

These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 19, 2024
@crisbeto crisbeto requested a review from a team as a code owner June 19, 2024 07:03
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team June 19, 2024 07:03
@crisbeto crisbeto added the G This is is related to a Google internal issue label Jun 19, 2024
@crisbeto crisbeto removed the request for review from amysorto June 19, 2024 17:27
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2024
@crisbeto crisbeto merged commit 3550a87 into angular:main Jun 19, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Jun 19, 2024
…le nested triggers (#29280)

If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu.

These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.

(cherry picked from commit 3550a87)
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
…le nested triggers (angular#29280)

If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu.

These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants