fix(material/button): stack icons on top of touch target #29291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago we started stacking the button's text on top of the ripple and touch target for accessibility reasons, but we didn't apply the same to icons. Fixes angular#28888.
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
mmalerba
approved these changes
Jun 20, 2024
crisbeto
added a commit
that referenced
this pull request
Jun 25, 2024
crisbeto
added a commit
to crisbeto/tensorboard
that referenced
this pull request
Jul 3, 2024
An upcoming change in Angular Material (angular/components#29291) changes the `z-index` of icons which ended up putting it behind the notification dot. This change adds an explicit `z-index` to the dot to ensure that it's on top of the icon.
hoonji
pushed a commit
to tensorflow/tensorboard
that referenced
this pull request
Jul 3, 2024
An upcoming change in Angular Material (angular/components#29291) changes the `z-index` of icons which ended up putting it behind the notification dot. This change adds an explicit `z-index` to the dot to ensure that it's on top of the icon.
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
Some time ago we started stacking the button's text on top of the ripple and touch target for accessibility reasons, but we didn't apply the same to icons. Fixes angular#28888.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago we started stacking the button's text on top of the ripple and touch target for accessibility reasons, but we didn't apply the same to icons.
Fixes #28888.