Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): prevent tab header from collapsing when empty inside a drop list #29418

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 11, 2024

Adds a min-height to the tab header when it is placed inside a drop list. This is useful when dragging between connected lists since the header may collapse when it has no tabs.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 11, 2024
@crisbeto crisbeto requested a review from a team as a code owner July 11, 2024 08:40
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team July 11, 2024 08:40
@crisbeto crisbeto changed the title fix(material/tabs): prevent tab header from collapsing when empty fix(material/tabs): prevent tab header from collapsing when empty inside a drop list Jul 12, 2024
…ide a drop list

Adds a `min-height` to the tab header when it is placed inside a drop list. This is useful when dragging between connected lists since the header may collapse when it has no tabs.
@crisbeto crisbeto added the G This is is related to a Google internal issue label Jul 12, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 16, 2024
@crisbeto crisbeto merged commit 92ab713 into angular:main Jul 16, 2024
23 of 25 checks passed
crisbeto added a commit that referenced this pull request Jul 16, 2024
…ide a drop list (#29418)

Adds a `min-height` to the tab header when it is placed inside a drop list. This is useful when dragging between connected lists since the header may collapse when it has no tabs.

(cherry picked from commit 92ab713)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants