fix(cdk/drag-drop): remove preview after animate to placeholder animation completes #29439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion completes The comparison between the event target element and this._preview never returned true because this._preview is a class, and we need to compare its element instead. This regression was introduced in commit angular@ebab924#diff-65b82ba5c290701d792881e9e389e8f1961848abb740bb20940d4383dfae4eacL121-R117.
skrtheboss
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
approved these changes
Jul 16, 2024
…r animation completes Fix linting error
crisbeto
approved these changes
Jul 16, 2024
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Jul 16, 2024
…tion completes (#29439) * fix(cdk/drag-drop): remove preview after animate to placeholder animation completes The comparison between the event target element and this._preview never returned true because this._preview is a class, and we need to compare its element instead. This regression was introduced in commit ebab924#diff-65b82ba5c290701d792881e9e389e8f1961848abb740bb20940d4383dfae4eacL121-R117. * fixup! fix(cdk/drag-drop): remove preview after animate to placeholder animation completes Fix linting error (cherry picked from commit 5655661)
skrtheboss
deleted the
fix/cdk-drag-ref-preview-not-removed-afeter-animation-is-finished
branch
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison between the event target element and this._preview never returned true because this._preview is a class, and we need to compare its element instead. This regression was introduced in commit ebab924#diff-65b82ba5c290701d792881e9e389e8f1961848abb740bb20940d4383dfae4eacL121-R117.