Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/form-field): hiding a label after it has been shown leaves a blank space #29461

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(material/form-field): hiding a label after it has been shown leaves a blank space #29461

merged 1 commit into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. fix(material/form-field): hiding a label after it has been 

    shown leaves a blank space

There is a method _shouldLabelFloat that determines if the label
should float. A check was added `_hasFloatingLabel` to see if a
floating label exists before deciding whether the label should
float. Examples were added at the end of the input-demo file,
where you can see inputs without labels (both fixed and dynamic).
Removing the solution also allows you to simulate the described
error. Unit tests were added to validate the solution.

Fixes angular#29401
    @jullierme
    jullierme committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b93e0fd View commit details
    Browse the repository at this point in the history