Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): stop manually instantiating MatRipple directive #29630

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

crisbeto
Copy link
Member

Previously we had to manually instantiate MatRipple in order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI in MatRipple and it prevented us from switching to the inject function.

Instantiating MatRipple is no longer necessary after #29622 so these changes switch to creating an internal RippleRenderer instead.

Previously we had to manually instantiate `MatRipple` in order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI in `MatRipple` and it prevented us from switching to the `inject` function.

Instantiating `MatRipple` is no longer necessary after angular#29622 so these changes switch to creating an internal `RippleRenderer` instead.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 23, 2024
@crisbeto crisbeto requested a review from a team as a code owner August 23, 2024 07:02
@crisbeto crisbeto requested review from amysorto, andrewseguin and devversion and removed request for a team August 23, 2024 07:02
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This was also a case in the signal input migration

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2024
@crisbeto crisbeto merged commit d0e178b into angular:main Aug 23, 2024
25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants