fix(subheader): respect custom set aria role

references #216
angular · Sep 7, 2014 · 633eea0 · 633eea0
1 parent 9d3822c
commit 633eea0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/components/subheader/subheader.js b/src/components/subheader/subheader.js
@@ -30,9 +30,11 @@ function materialSubheaderDirective() {
   return {
     restrict: 'E',
     compile: function($el, $attr) {
-      $el.attr({
-        'role' : Constant.ARIA.ROLE.HEADING
-      });
+      if(!$attr.role) {
+        $el.attr({
+          'role' : Constant.ARIA.ROLE.HEADING
+        });
+      }
     }
   };
 }
diff --git a/src/components/subheader/subheader.spec.js b/src/components/subheader/subheader.spec.js
@@ -1,11 +1,16 @@
 describe('materialSubheader', function() {
   beforeEach(module('material.components.subheader'));
 
-  it('should set aria role', inject(function($compile, $rootScope) {
+  it('should set default aria role', inject(function($compile, $rootScope) {
     var $el = $compile('<material-subheader>Hello world!</material-header>')($rootScope);
     expect($el.attr('role')).toEqual('heading');
   }));
 
+  it('should respect a custom set aria role', inject(function($compile, $rootScope) {
+    var $el = $compile('<material-subheader role="button">Hello world!</material-header>')($rootScope);
+    expect($el.attr('role')).toEqual('button');
+  }));
+
   it('should preserve content', inject(function($compile, $rootScope) {
     var $scope = $rootScope.$new();
     $scope.to = 'world';