Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(layout): fix flew-grow and flex-shrink values for flex-xx='xx' ma…
Browse files Browse the repository at this point in the history
…rkup

flexboxes should be 50% on flex-md=50 breakpoint and 33% on flex-gt-md=33 breakpoint,etc
change flex-grow and flew-shrink values from '0' to '1'
Thx to @MartinMuzatko for his help!
  • Loading branch information
ThomasBurleson committed Oct 15, 2015
1 parent 77d4696 commit 9f70430
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions src/core/services/layout/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -133,40 +133,40 @@
$value : #{$i * 5 + '%'};

.#{$flexName}-#{$i * 5} {
flex: 0 0 #{$value};
flex: 1 1 #{$value};
max-width: #{$value};
max-height: 100%;
box-sizing: border-box;
}

.layout-row > .#{$flexName}-#{$i * 5},
.layout#{$name}-row > .#{$flexName}-#{$i * 5} {
flex: 0 0 #{$value};
flex: 1 1 #{$value};
max-width: #{$value};
max-height: 100%;
box-sizing: border-box;
}

.layout-column > .#{$flexName}-#{$i * 5},
.layout#{$name}-column > .#{$flexName}-#{$i * 5} {
flex: 0 0 #{$value};
flex: 1 1 #{$value};
max-width: 100%;
max-height: #{$value};
box-sizing: border-box;
}
}

.layout-row, .layout#{$name}-row {
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 0 0 33%; max-width: 33%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-34 , > .#{$flexName}-34 { flex: 0 0 34%; max-width: 34%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 0 0 66%; max-width: 66%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-67 , > .#{$flexName}-67 { flex: 0 0 67%; max-width: 67%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33%; max-width: 33%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-34 , > .#{$flexName}-34 { flex: 1 1 34%; max-width: 34%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66%; max-width: 66%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-67 , > .#{$flexName}-67 { flex: 1 1 67%; max-width: 67%; max-height: 100%; box-sizing: border-box; }
}
.layout-column, .layout#{$name}-column {
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 0 0 33%; max-width: 100%; max-height: 33%; box-sizing: border-box; }
> .#{$flexName}-34 , > .#{$flexName}-34 { flex: 0 0 34%; max-width: 100%; max-height: 34%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 0 0 66%; max-width: 100%; max-height: 66%; box-sizing: border-box; }
> .#{$flexName}-67 , > .#{$flexName}-67 { flex: 0 0 67%; max-width: 100%; max-height: 67%; box-sizing: border-box; }
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33%; max-width: 100%; max-height: 33%; box-sizing: border-box; }
> .#{$flexName}-34 , > .#{$flexName}-34 { flex: 1 1 34%; max-width: 100%; max-height: 34%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66%; max-width: 100%; max-height: 66%; box-sizing: border-box; }
> .#{$flexName}-67 , > .#{$flexName}-67 { flex: 1 1 67%; max-width: 100%; max-height: 67%; box-sizing: border-box; }
}
}

Expand Down

2 comments on commit 9f70430

@Splaktar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasBurleson these changes mean that the layout docs need to be updated. Would you like me to submit a PR with those updates?

@ThomasBurleson
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Splaktar - yes please.

Please sign in to comment.