Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-card action bar padding and margins between icon buttons should be 8px #2403

Closed
asans opened this issue Apr 18, 2015 · 0 comments
Closed
Assignees
Milestone

Comments

@asans
Copy link

asans commented Apr 18, 2015

This affects v0.9.0-rc1-master-c964609.

md-card's md-card-footer style uses a padding of 16px. However, based on material specs for cards, it should be 8px.

components_cards33

Of course, it may depend on what is meant by footer in this case. I assume footer can be used as the action bar. However, if the two are significantly different in the use and purpose, there should probably be another style (class="md-action-bar") or element (md-action-bar or something similar to md-dialog) set for this.

Additionally, margins between two normal buttons should be 8px. Right now, it is 8px on each side of the button, creating a total of 16px spacing between two buttons.

@ThomasBurleson ThomasBurleson added this to the 0.9.0 milestone Apr 18, 2015
marcysutton added a commit that referenced this issue Apr 19, 2015
Card sections use DOM source order rather than flex order. This makes it so that an action bar can go in between content and the footer, and have any number of combinations.

Closes #2403
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 19, 2015
@marcysutton marcysutton removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 19, 2015
marcysutton added a commit that referenced this issue Apr 19, 2015
Card sections use DOM source order rather than flex order. This makes it so that an action bar can go in between content and the footer, and have any number of combinations.

Closes #2403
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants