md-dialog: forced padding

[michaelkrog]

I'm a bit unsure about the specs regarding using tabs in dialogs, but I do have an issue with it.

The md-dialog-content tag has a forced padding of 24px. Putting an md-tabs inside that makes it look like this:

If I set style:"padding:0px" on md-dialog-content, then it looks much better:

[EladBezalel]

@michaelkrog can you please check if It's still happening on HEAD?

[michaelkrog]

@EladBezalel Yes, it seems so.

http://plnkr.co/edit/2QzUUmtVRvTwjZIX1WxY?p=preview

[ThomasBurleson]

• For the Tabs demo's use class="md-padding" which adds padding:16px;; I have removed the padding for the first demo (to show how the tabs snaps to the parent container).
• Here is one of our Dialog demos with and without padding:
  
  

You can see why we offer padding as a default. But it is easy enough to override.

For the Dialog, if you do not want padding just do this in your custom CSS:

md-dialog-content {
  padding : 0;
}

[EladBezalel]

@ThomasBurleson maybe we should make .md-dialog-content class that users can put on their content and not force padding on the element

[ThomasBurleson]

@EladBezalel - great idea. Make it so!

[michaelkrog]

I like the fact that padding is not forced, but the implementation is a bit confusing.

HTML example

 <md-dialog-content>
    <div class="md-dialog-content">
     ....
   </div>
 </md-dialog-content>

We already have directives that tell whether padding should be added or not. Why introduce another css class? And then a class that carries the same name as a directive?

Would'nt it be more simple to have it like this?

<md-dialog-content layout-padding>
</md-dialog-content>

Or if 'layout-padding' does not quite fit here, perhaps this:

<md-dialog-content padding="true">
</md-dialog-content>