Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Md-icon with md-input vertical align #5731

Closed
peio72 opened this issue Nov 14, 2015 · 1 comment
Closed

Md-icon with md-input vertical align #5731

peio72 opened this issue Nov 14, 2015 · 1 comment
Assignees
@EladBezalel
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0.5

Comments

@peio72
Copy link

peio72 commented Nov 14, 2015

The md-icon used with md-input is not correctly vertical centered.(Too high from text label)

Viewable on actual demo.
devversion added a commit to devversion/material that referenced this issue Nov 14, 2015
@devversion
fix(input): calculate icon vertical offset
6bd7d97 
This centers the icon in the middle as required.

Fixes angular#5731
@devversion devversion mentioned this issue Nov 14, 2015
Closed
@devversion
Copy link
Member

Here is the PR, which fixes that #5732

devversion added a commit to devversion/material that referenced this issue Dec 10, 2015
@devversion
fix(input): calculate icon vertical offset
db974c0 
This centers the icon in the middle as required.

Fixes angular#5731
devversion added a commit to devversion/material that referenced this issue Jan 2, 2016
@devversion
fix(input): calculate icon vertical offset
1ffdbbf 
This centers the icon in the middle as required.

Fixes angular#5731
devversion added a commit to devversion/material that referenced this issue Jan 2, 2016
@devversion
fix(input): calculate icon vertical offset
4e4b685 
This aligns the icons as prefered in the material specs.

Fixes angular#5731
devversion added a commit to devversion/material that referenced this issue Jan 2, 2016
@devversion
fix(input): calculate icon vertical offset
8cb5bfb 
This aligns the icons as prefered in the material specs.

Fixes angular#5731
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
@devversion
fix(input): calculate icon vertical offset
0cf7e7b 
This aligns the icons as prefered in the material specs.

Fixes angular#5731
@EladBezalel EladBezalel added this to the 1.0.3 milestone Jan 9, 2016
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Jan 10, 2016
@ThomasBurleson ThomasBurleson added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.3, 1.0.4 Jan 22, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.4, 1.0.5 Jan 30, 2016
devversion added a commit to devversion/material that referenced this issue Feb 2, 2016
@devversion
fix(input): calculate icon vertical offset
5b3311d 
This aligns the icons as prefered in the material specs.

Fixes angular#5731
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
@devversion @ErinCoughlan
fix(input): calculate icon vertical offset
767fa9e 
This aligns the icons as prefered in the material specs.

Fixes angular#5731. Closes angular#5732.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
4 participants
@ThomasBurleson @devversion @EladBezalel @peio72