Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-select misplaced #6190

Closed
chr22 opened this issue Dec 9, 2015 · 5 comments
Closed

md-select misplaced #6190

chr22 opened this issue Dec 9, 2015 · 5 comments
Labels
g3: reported The issue was reported by an internal or external product team.
Milestone
1.0.1

Comments

@chr22
Copy link

chr22 commented Dec 9, 2015

md-select is misplaced when you select something far down the list. The further down the list, the more misplaced.

image

1.0-rc6, 1.0-rc7 and master.

Tested in Chrome, Firefox and Edge on Windows 10.
@treyhoover
Copy link

👍

1 similar comment
@murphmar
Copy link

+1

@andrew-cunliffe
Copy link

👍 same on latest safari - somewhat annoying to use 😆

@amritk
Copy link

amritk commented Dec 12, 2015

+1, gets pretty bad sometimes
screen shot 2015-12-11 at 5 03 38 pm

@richieforeman
Copy link

+1

@murphmar murphmar mentioned this issue Dec 15, 2015
Closed
@topherfangio topherfangio added this to the 1.01 milestone Dec 15, 2015
@naomiblack naomiblack added the g3: reported The issue was reported by an internal or external product team. label Dec 16, 2015
topherfangio added a commit that referenced this issue Dec 16, 2015
@topherfangio
fix(select): Position incorrect if selection scrolled.
d488e4b 
If the currently selected object scrolled into view because it
was further down in the list, the position of the menu was
incorrect upon opening because the `scrollTop` of the `contentNode`
was always `0` due to the ARIA changes which set it to
`display: none` upon closing.

Fix by modifying the display to `block` when we run the `isScrollable`
check and back afterward (usually `display: none` but we account for
other options).

Fixes #6190.
@topherfangio topherfangio mentioned this issue Dec 16, 2015
Closed
topherfangio added a commit that referenced this issue Dec 16, 2015
@topherfangio
fix(select): Position incorrect if selection scrolled.
c69e486 
If the currently selected object scrolled into view because it
was further down in the list, the position of the menu was
incorrect upon opening because the `scrollTop` of the `contentNode`
was always `0` due to the ARIA changes which set it to
`display: none` upon closing.

Fix by modifying the display to `block` when we run the `isScrollable`
check and back afterward (usually `display: none` but we account for
other options).

Also fixes a slight `2px` positioning issue which made the menu not
perfectly line up with the underlying selection.

Fixes #6190.
topherfangio added a commit that referenced this issue Dec 17, 2015
@topherfangio
fix(select): Position incorrect if selection scrolled.
b8e92d7 
If the currently selected object scrolled into view because it
was further down in the list, the position of the menu was
incorrect upon opening because the `scrollTop` of the `contentNode`
was always `0` due to the ARIA changes which set it to
`display: none` upon closing.

Fix by modifying the display to `block` when we run the `isScrollable`
check and back afterward (usually `display: none` but we account for
other options).

Also fixes a slight `2px` positioning issue which made the menu not
perfectly line up with the underlying selection.

Fixes #6190.
topherfangio added a commit that referenced this issue Dec 17, 2015
@topherfangio
fix(select): Position incorrect if selection scrolled.
81acf67 
If the currently selected object scrolled into view because it
was further down in the list, the position of the menu was
incorrect upon opening because the `scrollTop` of the `contentNode`
was always `0` due to the ARIA changes which set it to
`display: none` upon closing.

Fix by modifying the display to `block` when we run the `isScrollable`
check and back afterward (usually `display: none` but we account for
other options).

Also fixes a slight `2px` positioning issue which made the menu not
perfectly line up with the underlying selection.

Fixes #6190.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
g3: reported The issue was reported by an internal or external product team.
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

fix(select): Position incorrect if selection scrolled. angular/material
8 participants
@topherfangio @andrew-cunliffe @richieforeman @amritk @naomiblack @chr22 @murphmar @treyhoover