This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
$mdutil.findFocusTarget uses scope() which will not work if debug information is turned off #6474
Labels
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
pr: merge ready
This PR is ready for a caretaker to review
Milestone
Comments
This isn't the first issue where |
ThomasBurleson
added
the
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
label
Jan 15, 2016
topherfangio
added a commit
to profoundry-us/material
that referenced
this issue
Jan 19, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Fixes angular#6474.
topherfangio
added a commit
to profoundry-us/material
that referenced
this issue
Jan 19, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Fixes angular#6474.
topherfangio
added a commit
to profoundry-us/material
that referenced
this issue
Jan 19, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Fixes angular#6474.
topherfangio
added a commit
to profoundry-us/material
that referenced
this issue
Jan 19, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Fixes angular#6474.
topherfangio
added
the
pr: merge ready
This PR is ready for a caretaker to review
label
Jan 20, 2016
topherfangio
added a commit
to profoundry-us/material
that referenced
this issue
Jan 21, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Remove unused function `$mdUtil.validateScope()`. Fixes angular#6474.
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this issue
Feb 9, 2016
A few places use `element.scope()` to retrieve the proper scope, however, this is only available when Angular's debugging option is enabled and thus fails in production. Replace usages of `.scope()` in `util.js` and `datepicker.js` with appropriate alternatives. Remove unused function `$mdUtil.validateScope()`. Fixes angular#6474. Closes angular#6770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
pr: merge ready
This PR is ready for a caretaker to review
The scope() function is only available if debug information is available! Evaluating the expression assigned to the focus attribute will break as soon as this is turned off in production.
The text was updated successfully, but these errors were encountered: