Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

$mdDialog position not updating when escapeToClose set to false #6876

Closed
depyronick opened this issue Jan 27, 2016 · 7 comments
Closed

$mdDialog position not updating when escapeToClose set to false #6876

depyronick opened this issue Jan 27, 2016 · 7 comments

Comments

@depyronick
Copy link

You can see it in action on plunkr: https://plnkr.co/edit/EC9CexUlBa41jrrpybdJ?p=preview

  1. click on escapeToClose: true, resize window height and dialog stays centered and its height updating as you resize window. as expected.
  2. click on escapeToClose: false, resize window height and dialog do not update its height and not staying centered.

Is this a bug or am i missing something?

@devversion
Copy link
Member

Escape: True

Escape: False

Both works as expected

@depyronick
Copy link
Author

It's okay with width, but not with height:

escapeToClose: true

true

escapeToClose: false

false

btw @ThomasBurleson why do you keep closing issue without any word?

@devversion
Copy link
Member

@ThomasBurleson Sorry for that - Can reproduce now - only with height
@AliPoder - My fault, I think Thomas thought, everything works, because of my GIF's

Working on a fix, found the problem.

@depyronick
Copy link
Author

Oh, okay! Thank you :}

@depyronick
Copy link
Author

Also, as you can see on first gif, when you increase the height of window, the height of dialog not growing. i think #6871 points the same.

devversion added a commit to devversion/material that referenced this issue Jan 27, 2016
The current resize listeners for the window are misplaced inside of the condition of `escapeToClose == true`.

Fixes angular#6876
@devversion
Copy link
Member

@AliPoder @ThomasBurleson - Fix is done - See #6878.
PS: I don't think it is related to #6871, because the issue was described by flexbox problems.

@depyronick
Copy link
Author

yeah, thanks it works! 👍

ThomasBurleson pushed a commit that referenced this issue Jan 28, 2016
The current resize listeners for the window are misplaced inside of the condition of `escapeToClose == true`.

Fixes #6876

  Closes #6878
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
The current resize listeners for the window are misplaced inside of the condition of `escapeToClose == true`.

Fixes angular#6876

  Closes angular#6878
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants