Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

$mdDialog.prompt should have a defaultValue option #7046

Closed
zbjornson opened this issue Feb 5, 2016 · 4 comments
Closed

$mdDialog.prompt should have a defaultValue option #7046

zbjornson opened this issue Feb 5, 2016 · 4 comments
Assignees
@devversion
Labels
has: Pull Request A PR has been created to address this issue

Comments

@zbjornson
Copy link

I missed this when I made this config...

To be a full replacement for window.prompt, we should be able to provide a default value.

https://developer.mozilla.org/en-US/docs/Web/API/Window/prompt
@ThomasBurleson
Copy link
Contributor

PRs welcomed.

@ThomasBurleson ThomasBurleson added this to the Backlog milestone Feb 5, 2016
@devversion
Copy link
Member

@zbjornson Already working on that? - Don't want to waste your work if already working on it :)

@zbjornson
Copy link
Author

@devversion I can't do it until this weekend, so please go ahead! Thanks for checking :)

devversion added a commit to devversion/material that referenced this issue Feb 9, 2016
@devversion
feat(dialog): add default value to prompt preset.
df9091e 
Fixes angular#7046
@devversion devversion mentioned this issue Feb 9, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Feb 27, 2016
@devversion
feat(dialog): add default value to prompt preset.
09d1765 
Fixes angular#7046
@devversion devversion added pr: merge ready This PR is ready for a caretaker to review and removed - PRs please! labels Feb 27, 2016
devversion added a commit to devversion/material that referenced this issue Mar 21, 2016
@devversion
feat(dialog): add default value to prompt preset.
f4c9822 
Fixes angular#7046
@devversion devversion self-assigned this Mar 28, 2016
@devversion devversion modified the milestones: Backlog, 1.1.3, 1.3.0 Apr 14, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.3.0, Backlog Apr 20, 2016
@ThomasBurleson ThomasBurleson added has: Pull Request A PR has been created to address this issue and removed pr: merge ready This PR is ready for a caretaker to review labels Apr 21, 2016
@angular-tools
Copy link

Hi, when will this be merged into the main branch?

This is a pretty useful feature because it makes the prompt dialogs more useful (like not asking the user where to send the test email again and filling it for him if there is a cookie present, etc).

devversion added a commit to devversion/material that referenced this issue May 27, 2016
@devversion
feat(dialog): add initial value option to prompt preset.
c3bb7e0 
Fixes angular#7046
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
has: Pull Request A PR has been created to address this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ThomasBurleson @zbjornson @Splaktar @devversion @angular-tools