Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-dialog: Tab dialog not showing all tabs before clicking on tab one #7048

Closed
ismarslomic opened this issue Feb 5, 2016 · 3 comments
Closed

md-dialog: Tab dialog not showing all tabs before clicking on tab one #7048

ismarslomic opened this issue Feb 5, 2016 · 3 comments
Labels
P0: critical Critical issues that must be addressed immediately.
Milestone
1.0.6

Comments

@ismarslomic
Copy link

Steps to reproduce the bug:

  1. Go to http://codepen.io/ismarslomic/pen/BjqjZP
  2. Press TAB DIALOG
  3. You will only see one tab with label "ONE", but actually it is three tabs
  4. When clicking on tab "ONE", tab 2 and 3 is displayed

Tested with Safari and Chrome on OS X

See attached screenshots

screen shot 2016-02-06 at 00 26 39

screen shot 2016-02-06 at 00 26 49
@ThomasBurleson
Copy link
Contributor

@robertmesserle - This bug recently manifested; not sure which commit broke this feature.

@ThomasBurleson ThomasBurleson added the P0: critical Critical issues that must be addressed immediately. label Feb 5, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.6 milestone Feb 5, 2016
@EladBezalel
Copy link
Member

@ThomasBurleson @robertmesserle bc55ac9 broke it

@robertmesserle robertmesserle mentioned this issue Feb 10, 2016
Closed
ThomasBurleson pushed a commit that referenced this issue Feb 12, 2016
@ThomasBurleson
fix(tabs): fixes tab math to address issues when used within dialog
463d5e3 
closes #7048

  Closes #7118
@devversion devversion mentioned this issue Feb 25, 2016
Closed
@jiffify
Copy link

jiffify commented Dec 2, 2016

using google chrome, cannot see third tab in dialog demo. I can see third tab using IE

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P0: critical Critical issues that must be addressed immediately.
Projects
None yet
Milestone
1.0.6
Development

Successfully merging a pull request may close this issue.

fix(tabs): fixes tab math to address issues when used within dialog
5 participants
@ThomasBurleson @robertmesserle @ismarslomic @EladBezalel @jiffify