Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdSlider: Left-most value for discrete slider shouldn't be hollow #7093

Closed
apokusin opened this issue Feb 9, 2016 · 3 comments
Closed

mdSlider: Left-most value for discrete slider shouldn't be hollow #7093

apokusin opened this issue Feb 9, 2016 · 3 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone

Comments

@apokusin
Copy link

apokusin commented Feb 9, 2016

Discrete sliders shouldn't have a hollow visual design when at left-most value.

Example from Angular Material 1.0.5:
Screenshot

Material Design Spec

Example from Material Design Spec:
Screenshot

@devversion
Copy link
Member

I bet this is already fixed in #6538 😄 Can you confirm?
cc @EladBezalel

@EladBezalel
Copy link
Member

Yep :)

@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Feb 27, 2016
EladBezalel added a commit that referenced this issue Feb 27, 2016
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 27, 2016
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
ThomasBurleson pushed a commit that referenced this issue Mar 2, 2016
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
@ThomasBurleson
Copy link
Contributor

Fixed with SHA e0abeb4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

No branches or pull requests

4 participants