Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

semi-colon key code #7228

Closed
ShaneZhengNZ opened this issue Feb 21, 2016 · 4 comments
Closed

semi-colon key code #7228

ShaneZhengNZ opened this issue Feb 21, 2016 · 4 comments
Labels
needs: feedback The issue creator or community need to respond to questions in this issue P4: minor Minor issues. May not be fixed without community contributions.

Comments

@ShaneZhengNZ
Copy link

It would be great if we can add semi-colon as a new key code in $mdConstant.KEY_CODE
@ThomasBurleson
Copy link
Contributor

Why?

@ThomasBurleson ThomasBurleson added needs: team discussion This issue requires a decision from the team before moving forward. needs: feedback The issue creator or community need to respond to questions in this issue and removed needs: team discussion This issue requires a decision from the team before moving forward. labels Feb 24, 2016
@ShaneZhengNZ
Copy link
Author

@ThomasBurleson Because I would like to use semi-colon as a key separator for md-chips. It is quite common to allow semi-colon as a tag separator, for example, stackOverFlow. I am hard-coded the code into my script, but it would be good if it is part of the constant.

@ThomasBurleson
Copy link
Contributor

@ShaneZheng - seems reasonable.

@ThomasBurleson ThomasBurleson added this to the Backlog milestone Feb 26, 2016
@ThomasBurleson ThomasBurleson added the P4: minor Minor issues. May not be fixed without community contributions. label Feb 26, 2016
@ThomasBurleson
Copy link
Contributor

related to #6505

ThomasBurleson added a commit that referenced this issue Feb 27, 2016
@ThomasBurleson
fix(constants): add semicolon keycode
5e8cf9e 
Fixes #7228.
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs: feedback The issue creator or community need to respond to questions in this issue P4: minor Minor issues. May not be fixed without community contributions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomasBurleson @ShaneZhengNZ @Splaktar