Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng-show is not working on md-progress-circular #7454

Closed
jelbourn opened this issue Mar 8, 2016 · 2 comments
Closed

ng-show is not working on md-progress-circular #7454

jelbourn opened this issue Mar 8, 2016 · 2 comments
Assignees
@EladBezalel
Labels
g3: reported The issue was reported by an internal or external product team. P0: critical Critical issues that must be addressed immediately. pr: merge ready This PR is ready for a caretaker to review
Milestone
1.1.0

Comments

@jelbourn
Copy link
Member

jelbourn commented Mar 8, 2016

See the first progress-circular on the page:
http://codepen.io/jelbourn/pen/RareKa

cc @calebegg
@jelbourn jelbourn added g3: reported The issue was reported by an internal or external product team. P0: critical Critical issues that must be addressed immediately. labels Mar 8, 2016
@jelbourn jelbourn added this to the 1.1.0 milestone Mar 8, 2016
@ThomasBurleson
Copy link
Contributor

Another demo with issue http://codepen.io/anon/pen/grpNNO?editors=1000

cc @EladBezalel

EladBezalel added a commit that referenced this issue Mar 8, 2016
@EladBezalel
fix(progress-circular): removed dependency on ng-hide class
2f257b6 
- If the progress mode wasn't indeterminate or determinate it would use `ng-hide` class to hide it, and if it's a valid mode, `ng-hide` was removed, what caused `ng-hide` not to preform as wanted.
Now when mode is not indeterminate or determinate set it default to indeterminate

fixes #7454
@EladBezalel EladBezalel added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 8, 2016
EladBezalel added a commit that referenced this issue Mar 8, 2016
@EladBezalel
fix(progress-circular): removed dependency on ng-hide class
77475b1 
- If the progress mode wasn't indeterminate or determinate it would use `ng-hide` class to hide it, and if it's a valid mode, `ng-hide` was removed, what caused `ng-hide` not to preform as wanted.
Now when mode is not indeterminate or determinate set it default to indeterminate

fixes #7454
@EladBezalel EladBezalel mentioned this issue Mar 8, 2016
Closed
@EladBezalel EladBezalel added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 8, 2016
@Frank3K
Copy link
Contributor

Frank3K commented Mar 8, 2016

Facing the same issue. Observed behavior: when the value for ng-show is constant (either true or false) it does not work. When the value is set later on (e.g. from an onLoaded callback) it does work (at least in my case).

EladBezalel added a commit that referenced this issue Mar 8, 2016
@EladBezalel
fix(progress-linear): changed default behavior of invalid mode
20409fe 
- Changed default mode to be `indeterminate`
- Removed `ng-hide` class appliance
- Fixed progress-circular demo

related to #7454
EladBezalel added a commit that referenced this issue Mar 8, 2016
@EladBezalel
fix(progress-linear): changed default behavior of invalid mode
2c8731b 
- Changed default mode to be `indeterminate`
- Removed `ng-hide` class appliance
- Fixed progress-circular demo

related to #7454
@EladBezalel EladBezalel mentioned this issue Mar 8, 2016
Closed
EladBezalel added a commit that referenced this issue Mar 8, 2016
@EladBezalel
fix(progress-linear): changed default behavior of invalid mode
41529da 
- Changed default mode to be `indeterminate`
- Removed `ng-hide` class appliance
- Fixed progress-circular demo

related to #7454
ThomasBurleson pushed a commit that referenced this issue Mar 8, 2016
@EladBezalel @ThomasBurleson
fix(progress-linear): changed default behavior of invalid mode
91ec2bf 
- Changed default mode to be `indeterminate`
- Removed `ng-hide` class appliance
- Fixed progress-circular demo

related to #7454

Closes #7470
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
g3: reported The issue was reported by an internal or external product team. P0: critical Critical issues that must be addressed immediately. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

fix(progress-circular): removed dependency on ng-hide class angular/material
4 participants
@ThomasBurleson @jelbourn @EladBezalel @Frank3K