Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Autocomplete ng-messages wrong font-size #7477

Closed
gpopovic opened this issue Mar 9, 2016 · 7 comments
Closed

Autocomplete ng-messages wrong font-size #7477

gpopovic opened this issue Mar 9, 2016 · 7 comments
Assignees
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.

Comments

@gpopovic
Copy link

gpopovic commented Mar 9, 2016

In master, ng-messages font size for autocomplete is wrong.

In codepen, you can compare input ng-message with autocomplete ng-message
http://codepen.io/anon/pen/ONNgMQ

@devversion
Copy link
Member

Great demo, I'll take a look at this soon.

@gpopovic
Copy link
Author

@devversion , any updates on this one?

@topherfangio topherfangio added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Mar 17, 2016
@devversion
Copy link
Member

Just investigated a bit and it seems to relate to the scope transclusion.

I tried to create a scope transclusion myself to take a look at its most elegant solution.

http://codepen.io/DevVersion/pen/WwRqaO?editors=1010

So just want to notify you, that this issue is in progress.

@devversion devversion added the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Mar 18, 2016
@EladBezalel
Copy link
Member

This is related to the styles applied,
Take a look at input messages style

@devversion
Copy link
Member

@EladBezalel Yes actually it is related to the styes. But updating the style selectors won't be the right solution, because the ngMessage isn't retrieving the animation class correctly.

This is caused by the parent transclusion from the autocomplete.

(https://github.com/angular/material/blob/master/src/components/input/input.js#L711)

@EladBezalel
Copy link
Member

👍

@cairomassimo
Copy link

I am not sure if this may helps:

Pull request #5637 removed the code the replaces a wrapper div generated by mdAutocomplete. See this line:
05d7f24#diff-f700fe0b273e851967e22440f2c464eeL25
Also, see the occurences of the string md-autocomplete-replace in the whole repository. It was used as a marker class on the div to remove, but it is never taken into account.

Since mdInputContainer requires ngMessages to be a direct child, this might be the cause of the problem.

devversion added a commit to devversion/material that referenced this issue May 9, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596.
devversion added a commit to devversion/material that referenced this issue May 9, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596.
@devversion devversion added has: Pull Request A PR has been created to address this issue and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels May 9, 2016
devversion added a commit to devversion/material that referenced this issue May 18, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596. Fixes angular#6810. Fixes angular#7823
devversion added a commit to devversion/material that referenced this issue May 18, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596. Fixes angular#6810. Fixes angular#7823
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Development

No branches or pull requests

7 participants