Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-input textarea is broken as earlier #7487

Closed
jalajc opened this issue Mar 9, 2016 · 7 comments
Closed

md-input textarea is broken as earlier #7487

jalajc opened this issue Mar 9, 2016 · 7 comments
Assignees
Labels
P4: minor Minor issues. May not be fixed without community contributions.
Milestone

Comments

@jalajc
Copy link

jalajc commented Mar 9, 2016

md-input textarea is broken as earlier in #2007
Bug is even in 1.06

  1. scroll-bar is not appearing
  2. when in md-no-autogrow just one line of text appears (even if rows= 5, and one has 3 lines of text)
  3. md-select-on-focus: just flashes the select and then select disappears.
@ThomasBurleson ThomasBurleson added the P4: minor Minor issues. May not be fixed without community contributions. label Mar 9, 2016
@ThomasBurleson ThomasBurleson added this to the 1.2.0 milestone Mar 9, 2016
@crisbeto
Copy link
Member

@jalajc I've fixed 1 and 2, however I can't reproduce 3. Do you have any more info?

@jalajc
Copy link
Author

jalajc commented Mar 13, 2016

for 3: Check the first demo (Basic Usage) at https://material.angularjs.org/latest/demo/input
Notice behavior for textarea: 'Biography'.
When you click on text, text flashes and disappears (you make have to click on text and outside at multiple times-it was little unpredictable today!)

@crisbeto
Copy link
Member

Ah I see what you mean. It doesn't happen on Chrome, but it definitely does on Firefox. For reference:

select

@jalajc
Copy link
Author

jalajc commented Mar 13, 2016

Thanks for the gif grab, that's what I was referring to.
apparently, this is happening for me on chrome too, Version 43.0.2357.132 m.

@devversion
Copy link
Member

This is only happening if you hit the cursor between the chars.

@crisbeto
Copy link
Member

Not quite sure that's the case, here me trying to hit right in the middle of the "m". The gif recording app seems to move the cursor slightly though:

select

@crisbeto
Copy link
Member

Seems like a mouseup event is being fired right after the focus. Preventing the default solves it but makes for a crappy user experience.

crisbeto added a commit to crisbeto/material that referenced this issue Mar 13, 2016
* Fixes `mdSelectOnFocus` not working in Edge and being unreliable in Firefox.
* Fixes `textarea` not being scrollable once it is past it's minimum number of rows.
* Fixes `textarea` not being scrollable if `mdNoAutogrow` is specified.
* Tries to reduce the number of event listeners and the amount of DOM manipulation when resizing the `textarea`.

Closes angular#7487.
crisbeto added a commit to crisbeto/material that referenced this issue Mar 13, 2016
* Fixes `mdSelectOnFocus` not working in Edge and being unreliable in Firefox.
* Fixes `textarea` not being scrollable once it is past it's minimum number of rows.
* Fixes `textarea` not being scrollable if `mdNoAutogrow` is specified.
* Tries to reduce the number of event listeners and the amount of DOM manipulation when resizing the `textarea`.

Closes angular#7487.
crisbeto added a commit to crisbeto/material that referenced this issue Mar 14, 2016
* Fixes `mdSelectOnFocus` not working in Edge and being unreliable in Firefox.
* Fixes `textarea` not being scrollable once it is past it's minimum number of rows.
* Fixes `textarea` not being scrollable if `mdNoAutogrow` is specified.
* Tries to reduce the number of event listeners and the amount of DOM manipulation when resizing the `textarea`.

Closes angular#7487.
ThomasBurleson pushed a commit that referenced this issue Mar 16, 2016
* Fixes `mdSelectOnFocus` not working in Edge and being unreliable in Firefox.
* Fixes `textarea` not being scrollable once it is past it's minimum number of rows.
* Fixes `textarea` not being scrollable if `mdNoAutogrow` is specified.
* Tries to reduce the number of event listeners and the amount of DOM manipulation when resizing the `textarea`.

Fixes #7487. Closes #7553
@Splaktar Splaktar modified the milestones: 1.2.0, 1.1.6 Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4: minor Minor issues. May not be fixed without community contributions.
Projects
None yet
Development

No branches or pull requests

5 participants