Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-colors default theme #8407

Closed
hodeyp opened this issue May 11, 2016 · 4 comments
Closed

md-colors default theme #8407

hodeyp opened this issue May 11, 2016 · 4 comments
Assignees
@EladBezalel
Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Milestone
1.1.0

Comments

@hodeyp
Copy link

hodeyp commented May 11, 2016 •
edited by ThomasBurleson
Loading

Actual behavior:

  • What is the issue? * md-colors uses the default theme as the [theme] which means if a component has an md-theme entry as well as an md-colors entry the md-colors is not using the correct md-theme
  • What is the expected behaviour?

CodePen or Steps to reproduce the issue: *

 <md-card flex md-theme="secondary" md-colors="{'background': 'background-800'}">

Angular Versions: *

  • Angular Version: 1.5.5
  • Angular Material Version: 1.0.8

Additional Information:

  • Browser Type: * all
  • Browser Version: * all
  • OS: * all
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.
@EladBezalel
Copy link
Member

@hodeyp hey can you provide a codepen?

Please have in mind that without a codepen this issue will be rejected

@EladBezalel EladBezalel added the needs: more info The issue does not contain enough information for the team to determine if it is a real bug label May 12, 2016
@hodeyp
Copy link
Author

hodeyp commented May 12, 2016 •
edited
Loading

@EladBezalel I have added a codepen reference above, let me know if you need any more information.

@EladBezalel EladBezalel added P2: required Issues that must be fixed. and removed needs: more info The issue does not contain enough information for the team to determine if it is a real bug labels May 13, 2016
@EladBezalel EladBezalel self-assigned this May 13, 2016
@EladBezalel
Copy link
Member

👍 for now you can use secondary-primary-800

@ThomasBurleson
Copy link
Contributor

@hodeyp - great avatar!

@ThomasBurleson ThomasBurleson added this to the 1.1.0 milestone May 18, 2016
EladBezalel added a commit that referenced this issue May 19, 2016
@EladBezalel
feat(colors): mdTheme integration
92cad9f 
- If `md-theme` directive is somewhere up the DOM tree we inject the theme before each color value

 ### example
```html
<div md-theme="myTheme">
  <div md-colors="{background: 'primary-600'}">
    <span md-colors="{background: 'mySecondTheme-accent-200'}">Color demo</span>
  </div>
</div>
```
 `'primary-600'` will be `'myTheme-primary-600'`,
but `'mySecondTheme-accent-200'` will stay the same cause it has a theme prefix

fixes #8407
@EladBezalel EladBezalel mentioned this issue May 19, 2016
Closed
@EladBezalel EladBezalel added the has: Pull Request A PR has been created to address this issue label May 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat(colors): mdTheme integration angular/material
3 participants
@ThomasBurleson @hodeyp @EladBezalel