Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Responsive layout fix #1086

Closed
wants to merge 1 commit into from
Closed

Responsive layout fix #1086

wants to merge 1 commit into from

Conversation

marcysutton
Copy link
Contributor

To address issues in #962, this PR includes a style refactor for mdToolbar and markup changes in the docs.

An update to the toolbar icons will come later as part of #916 (removing icon text and updating artwork to be more semantic).

Closes #962

@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Dec 31, 2014
@gkalpak
Copy link
Member

gkalpak commented Jan 2, 2015

The implementation and semantics of hide-lt-md are wrong.
If nothing else it sounds more like a hide-lt-lg.

This again brings up the issue raised in #772 (which has been long ignored/"neglected"), namely:
show-/hide-{size} attributes are implemented in a way that is (more or less) wrong.

@marcysutton
Copy link
Contributor Author

Yes, I had trouble figuring out what attributes to use. The combination I thought would accomplish what I wanted (hide something when the screen is less than 960w) was [hide][show-gt-md] but it didn't didn't hide anything, if I remember correctly. If there's an attribute combination that accomplishes what I'm after without adding a new attribute, sweet! If we can keep this issue moving forward without being delayed by another outstanding one, that would be ideal.

@mzbyszynski
Copy link
Contributor

@marcysutton hide-sm hide-md should work, if you don't mind the verbosity...

@marcysutton
Copy link
Contributor Author

Thanks–I've updated the code to work without adding a new attribute. They could definitely be more intuitive.

@marcysutton marcysutton added resolution: fixed and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Jan 2, 2015
@marcysutton marcysutton closed this Jan 7, 2015
@marcysutton marcysutton deleted the wip-responsive-layoutfix branch January 7, 2015 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive design can be improved for small devices
4 participants