This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(fabSpeedDial/fabToolbar): support positioning using fab button c… #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
needs: feedback
|
This is not quite ready for merge, and I would love feedback on the approach. However, I am a bit confused as to why it didn't pass the @ThomasBurleson Thoughts? Edit: Looks like the current master has a |
|
@topherfangio - I like the refactoring; but let's create a |
ThomasBurleson
added
in progress
|
Thanks! I'll get this done and ping you when it's ready. |
|
@topherfangio - Is this PR still valid. It fails the CI tests. Can you rebase and update the tests ? |
|
@ThomasBurleson Sorry for the delay, will definitely get this updated/ready for merge :-) |
topherfangio
force-pushed
the
wip/speed_dial_positions
branch
from
80702eb
to
f5e1cdf
Compare
|
@ThomasBurleson Updated PR, can you please take a look and see if it is ready for merge now? |
topherfangio
force-pushed
the
wip/speed_dial_positions
branch
from
b1faa4f
to
d6d3c8c
Compare
topherfangio
added
pr: merge ready
…lasses refactor button.scss and fab*.scss to share fab position variables/mixins fixes #3220
topherfangio
force-pushed
the
wip/speed_dial_positions
branch
from
d6d3c8c
to
f5c5faf
Compare
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
…lasses refactor button.scss and fab*.scss to share fab position variables/mixins fixes angular#3220. closes angular#3693.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor button.scss to share fab position variables/mixins across speed dial/; would
LOVE feedback on whether or not this is the best approach
references #3220