This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdTabs): Fix 0-height animation on iOS devices. #4341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $element.css(oldCssHeight); | ||
|
|
||
| // Animate the height from the old to the new | ||
| $animate.animate($element, oldCssHeight, newCssHeight).then(function () { |
There was a problem hiding this comment.
why not use $animateCss(element, { from, to, duration } ).start( )?
There was a problem hiding this comment.
It was using $animate so I didn't want to alter the existing code too much, but I'll give this a try and run all of the tests.
On iOS devices, when switching between tabs, the height would jump to 0, then animate to the proper place causing a bad glitch. Fixes #4339
topherfangio
force-pushed
the
fix-tabs-ios-height-4339
branch
from
1600ba6
to
a89f141
Compare
topherfangio
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
On iOS devices, when switching between tabs, the height would jump to 0, then animate to the proper place causing a bad glitch. Fixes angular#4339. Closes angular#4341.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS devices, when switching between tabs, the height would jump
to 0, then animate to the proper place causing a bad glitch.
Fixes #4339