This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(layout): Set the initial height to inherit the parent. #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
|
@ThomasBurleson Per your request, I tested the demo site in all three browsers and did not see any difference in adding this additional property. |
topherfangio
added
needs: review
|
@ThomasBurleson Everything was passing locally for me, but when it failed on Travis, I removed my |
|
The issue is something in the latest Angular 1.4.5 release. @petebacondarwin, @matsko - can you guys help use investigate? Angular 1.4.4 works fine with our tests and Karma.... Angular 1.4.5 causes many failures. |
|
@topherfangio - I temporarily locked our Angular version to 1.4.4; see package.json. |
topherfangio
force-pushed
the
fix-layout-height-inherit
branch
from
a7fc85f
to
c73ceef
Compare
topherfangio
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
call `checkCloseMenu(ev)` with `ev` argument. ensure references to `ev` are non-null Fixes angular#4377. Closes angular#4384. Closes angular#4372.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, browsers have issues with rendering flex layouts
when the height of an element is not set. This simply forces each
layout element (which is the most common case when using flex) to
the height it would normally be.
Also fixes random icon padding in demo causing the icon to be
mis-aligned.
Fixes #4022. References #3901. Fixes #4130.