Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(docs): fix animation for menu-toggle #6937

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Little explanation:

  • When opening demo through link (example: http://127.0.0.1:8080/#/demo/bottomSheet), we need to wait for the ul being rendered. (using the next tick)
  • So I register the complete watcher in the next tick without affecting the current code.
  • The current problem for the open animation is, that we read the height in the timeout, so we need to move that out -> but then it won't wait for the ul to be rendered on opening through link. So as I did, we need to delay the watcher registration - and everything works.

Refrences #6579 References #6572 Fixes #6262 Fixes #6936

@ThomasBurleson ThomasBurleson added this to the 1.0.5 milestone Feb 1, 2016
@ThomasBurleson ThomasBurleson assigned tbosch and ThomasBurleson and unassigned tbosch Feb 1, 2016
@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Feb 1, 2016
ThomasBurleson pushed a commit that referenced this pull request Feb 1, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
@devversion devversion deleted the fix/docs-menu-toggle branch April 21, 2016 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants