Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): fix autocomplete tabindex support #7005

Closed

Conversation

devversion
Copy link
Member

  • We should always apply to the root directive a tabindex of -1
  • We should direct the tabindex to the input (if tabindex is specified)
  • Added accompanying tests

Fixes #6999

- We should always apply to the root directive a tabindex of `-1`
- We should direct the tabindex to the input (if tabindex is specified)
- Added accompanying tests

Fixes angular#6999
@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Feb 4, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.5 milestone Feb 4, 2016
@ThomasBurleson ThomasBurleson self-assigned this Feb 4, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
- We should always apply to the root directive a tabindex of `-1`
- We should direct the tabindex to the input (if tabindex is specified)
- Added accompanying tests

Fixes angular#6999. Closes angular#7005
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
- We should always apply to the root directive a tabindex of `-1`
- We should direct the tabindex to the input (if tabindex is specified)
- Added accompanying tests

Fixes #6999. Closes #7005

# Conflicts:
#	src/components/autocomplete/autocomplete.spec.js
@devversion devversion deleted the fix/autocomplete-tabindex branch April 21, 2016 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants