Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Adds ability to override [flex] attributes under different media queries... #707

Closed

Conversation

jamesspencer
Copy link

... as described in #706

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@jamesspencer
Copy link
Author

Ack, used wrong email when submitting the PR. I've changed my GitHub public email to the same as that which I signed the CLA with. LMK if you would like this submitted again!

@alanrussian
Copy link

I believe this would only account for the 100% case (e.g., flex-phone="100"). It would not account for something like flex-phone="25" which worked before (as flex-sm).

@jamesspencer
Copy link
Author

@alanrussian the 100% case appears to be missing from the latest release, AFAICT the intermediary cases (flex-phone="25") are still working. Or do have I you confused?

@ajoslin ajoslin closed this in 7acca43 Nov 24, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Nov 24, 2014

Good call! merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants