This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(styles): define private css styles #7248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
This was referenced Feb 23, 2016
ThomasBurleson
added
needs: review
This was referenced Feb 23, 2016
|
@EladBezalel - input issues >
|
|
@topherfangio - List issues >
|
|
@EladBezalel - Switch and Tabs Issues > Switch
Tabs
|
ThomasBurleson
added
the
in progress
topherfangio
force-pushed
the
feat/css-privates
branch
from
94ecffb
to
119641b
Compare
ThomasBurleson
added
pr: merge ready
Many components use classes that should be noted as private/internal classes. Update components accordingly by prefixing classes with `_md-`. Refactor the following components: * FAB SpeedDial/Toolbar * Backdrop * Subheader * Chips * Content Refactor the `md-visually-hidden` class to `_md-visually-hidden` across multiple components. Also make a slight change to icon docs for better readability. Refactor `<md-content>`'s `autoScroll` class to `md-no-momentum` for better clarity and to define it as a public API class and add appropriate docs. BREAKING CHANGE The `autoScroll` class of the `<md-content>` directive has been renamed to `md-no-momentum` to increase clarity and mark it as an API-level class. If you use the `autoScroll` class in your code, please update it to the new name `md-no-momentum`. Changed classes: * button: md-focused -> _md-focused * checkbox: md-label -> _md-label md-checked ->_md-checked md-icon ->_md-icon md-container -> _md-container md-focused -> _md-focused * progress-circular: md-spinner-wrapper -> _md-spinner-wrapper md-inner -> _md-inner md-gap -> _md-gap md-left -> _md-left md-right -> _md-right md-half-circle -> _md-half-circle md-scale-wrapper -> _md-scale-wrapper md-mode-indeterminate -> _md-mode-indeterminate * progress-linear: md-container -> _md-container md-bar -> _md-bar md-dashed -> _md-dashed md-bar1 -> _md-bar1 md-bar2 -> _md-bar2 md-mode-query -> _md-mode-query md-mode-determinate -> _md-mode-determinate md-mode-indeterminate -> _md-mode-indeterminate md-mode-buffer -> _md-mode-buffer * radio-button: md-container -> _md-container md-off -> _md-off md-on -> _md-on md-checked -> _md-checked md-label -> _md-label md-focu sed -> _md-focused circle -> DELETED * sidenav: md-closed -> _md-closed md-locked-open -> _md-locked-open md-sidenav-backdrop -> _md-sidenav-backdrop * slider: md-dragging -> _md-dragging md-active -> _md-active md-slider-wrapper -> _md-slider-wrapper md-track-container -> _md-track-container md-track -> _md-track md-track-fill -> _md-track-fill md-track-ticks -> _md-track-ticks md-thumb-container -> _md-thumb-container md-thumb -> _md-thumb md-sign -> _md-sign md-thumb-text -> _md-thumb-text md-focus-thumb -> _md-focus-thumb md-focus-ring -> _md-focus-ring md-disabled-thumb -> _md-disabled-thumb md-min -> _md-min * switch: md-container -> _md-container md-dragging -> _md-dragging md-focused -> _md-focused md-thumb -> _md-thumb md-bar -> _md-bar md-thumb-container -> _md-thumb-container md-checked -> _md-checked * toast: md-toast-animating -> _md-toast-animating md-bottom -> _md-bottom md-left -> _md-left md-right -> _md-right md-top -> _md-top md-swipeleft -> _md-swipeleft md-swiperight -> _md-swiperight md-swipeup -> _md-swipeup md-swipedown -> _md-swipedown * tooltip: md-content -> _md-content md-show -> _md-show md-hide -> _md-hide References #6653. Closes #6706. Closes #7239.
ThomasBurleson
force-pushed
the
feat/css-privates
branch
from
119641b
to
df60ee1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify public and private css styles
_name prefixes.