Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): Set vertical align on datepicker tables #7278

Conversation

jshoudy11
Copy link
Contributor

fixes #7111

@jshoudy11 jshoudy11 added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 24, 2016
@jshoudy11 jshoudy11 added this to the Pan - Q1 milestone Feb 24, 2016
@ThomasBurleson ThomasBurleson added - Breaking Change pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Feb 26, 2016
@ThomasBurleson
Copy link
Contributor

@conniew - is this ready for me to merge? LGTM

@jshoudy11
Copy link
Contributor Author

@ThomasBurleson I don't think this is a breaking change. It doesn't change the appearance on material.angularjs.org, only for those that have vertical-align:baseline set explicitly.

@conniew
Copy link

conniew commented Feb 26, 2016

The code LGTM, I trust you and Jake more with the process of merging, though.

@jshoudy11
Copy link
Contributor Author

@ThomasBurleson do you want me to push this through the command line from jshoudy11:feat/datepicker_align to angular:feat/datepicker_align and then create a PR to pull it into master separately? Or should that all be done from this PR?

@ThomasBurleson
Copy link
Contributor

@jshoudy11, @conniew - I was only going to merge this into master and minor branches.
@conniew - if the UI can possibly change as a result of the PR, we are call it a breaking change. And if the API changes, we also call it a breaking change (traditional).

@jshoudy11
Copy link
Contributor Author

@ThomasBurleson Okay. Should be ready for merge then.

@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, Pan - Q1 Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Breaking Change pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants