Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(icon): Allow using data URLs #7547

Closed
wants to merge 1 commit into from
Closed

fix(icon): Allow using data URLs #7547

wants to merge 1 commit into from

Conversation

programmist
Copy link
Contributor

Fixes #4126
This also opens another solution for #6531

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@programmist programmist added the needs: review This PR is waiting on review from the team label Mar 12, 2016
function loadByDataUrl(url) {
var results = dataUrlRegex.exec(url);
var isBase64 = /base64/i.test(url);
var data = isBase64 ? atob(results[2]) : results[2];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atob() is a global; let's use either $window.atob or window.atob

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ThomasBurleson ThomasBurleson added needs: unit tests This PR needs unit tests to cover the changes being proposed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 13, 2016
@ThomasBurleson
Copy link
Contributor

@programmist - nice work! 👍

@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: review This PR is waiting on review from the team needs: unit tests This PR needs unit tests to cover the changes being proposed labels Mar 17, 2016
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants