This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(theme): remove default background theme (grey) 1000 value
#7686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'A100': '#ffffff', | ||
| 'A200': '#eeeeee', | ||
| 'A200': '#000000', |
There was a problem hiding this comment.
Is this a deviation from the Material Design color palette ?
There was a problem hiding this comment.
grey doesn't have accent colors, we use it to host white, black and other colors from the spec
EladBezalel
added
pr: merge ready
- Other palettes doesn't have `1000` therefor when registering a new background palette 1000 couldn't be found fixes #7600
EladBezalel
force-pushed
the
fix/grey-theme-1000
branch
from
2d87870
to
fbe62a4
Compare
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
- Other palettes doesn't have `1000` therefor when registering a new background palette 1000 couldn't be found fixes angular#7600 Closes angular#7686
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1000therefor when registering a new background palette 1000 couldn't be foundfixes #7600