fix(aria): $mdAria should not use texts from aria-hidden nodes #7957
Conversation
devversion
added
a11y
|
FYI: Waiting for @topherfangio's fix for the current CI issues :) Thx. |
|
@devversion - please rebase. |
| var text = ''; | ||
|
|
||
| var node; | ||
| while (node = walker.nextNode()) { |
There was a problem hiding this comment.
Rather than walking through all of the nodes here, can you not just use the third parameter filter of the createTreeWalker() method? I would assume you could just pass the isAriaHiddenNoe() method to it (wrapped in an object I think) and it would filter the nodes for you.
I guess you would still have to traverse the remaining nodes to add the text content, but it might shorten the code for you a bit.
There was a problem hiding this comment.
@topherfangio I intentionally didn't use the filter for the TreeWalker, because it's not supported by IE browsers and this will break ngMaterial on IE browsers.
Additionally, the filter is actually doing the same as my code, it's just a shorter / native code + The amount of nodes we iterate through is really minimized, because we're only iterating through the text nodes.
* $mdAria is currently just using `textContent` for retrieving the `aria-label`. This is not valid, since some child-texts can be hidden in aria (`aria-hidden="true") * Using a TreeWalker is super elegant and performant. The current use of the TreeWalker is supported by all browser we support. Fixes angular#7376
devversion
force-pushed
the
fix/aria-textcontent-iteration
branch
from
c3de5d6
to
7a95f2a
Compare
|
@ThomasBurleson Done, thanks for the fix 👍 |
* $mdAria is currently just using `textContent` for retrieving the `aria-label`. This is not valid, since some child-texts can be hidden in aria (`aria-hidden="true") * Using a TreeWalker is super elegant and performant. The current use of the TreeWalker is supported by all browser we support. Fixes angular#7376 Closes angular#7957
textContentfor retrieving thearia-label.This is not valid, since some child-texts can be hidden in aria (`aria-hidden="true")
The current use of the TreeWalker is supported by all browser we support.
Fixes #7376