-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs(guides): several fixes (links, typos, syntax, line lengths) #837
Conversation
CLAs look good, thanks! |
A couple more notes/issues:
|
14ecdba
to
1e357b6
Compare
1e357b6
to
1aea2f1
Compare
It would be great if someone could take a look at this and merge it some time "soon-ish". It's purely docs. |
@gkalpak - I will review later this morning. |
|
||
![venn](https://cloud.githubusercontent.com/assets/210413/5077572/30dfc2f0-6e6a-11e4-9723-07c918128f4f.png) | ||
|
||
This project is in early pre-release. Angular Material is both a reference implementation of Material Design and a complementary effort to the [Polymer](http://www.polymer-project.org/) project's [Paper Elements](http://www.polymer-project.org/docs/elements/paper-elements.html) collection. | ||
This project is in early pre-release. Angular Material is both a reference implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, please add linebreaks as it makes side-by-side git reviews very difficult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason side-by-side review is difficult is because I have linebreaks, but the old version didn't. Basically, the original intent of this PR was to apply the max. 100 chars/line rule the docs, because the long lines made reviews difficult. So, hopefully, future reviews will be much easier :)
Will merge now. Thx @gkalpak |
@ThomasBurleson: Many thx for reviewing (and merging) - I know it was tedious. BTW, you might want to take a look at #837 (comment). |
@gkalpak - Will do. Thx for the alert. |
@gkalpak re > your comments above "A couple more notes/issues" (1) Fixed |
I started out fixing line-length to comply to the max. 100 chars per line rule (as discussed here), but this turned out to be a more generic error fixing:
The diff may seem a little weird due to the line-wrapping.
I have re-read all the modified documents and tried all the links (and everything seems fine), but a 2nd pair of eyes is always irreplaceable 😃