This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix($mdUtil) nextTick now keeps reference to correct scope. #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2016 15:11
Previously, `nextTick` would decide whether to run the functions based on the first `scope` argument passed during a given digest cycle. This could fail in multiple scenarios ... 1) The first `nextTick` call didn't supply a scope, but subsequent calls did. 2) Multiple components (with different scopes) registered callbacks during the same digest cycle. This could lead to callbacks being executed when they shouldn't be (if the first scope registered wasn't $$destroyed, this _this_ scope was), or callbacks not being executed when they should be (the first scope was $$destroyed, but this scope wasn't). I believe that this fixes #8358
|
I don't know how you guys feel about tiny cosmetic fixups being incorporated with a real change... If you'd rather, I can drop 0ea79f2 from this PR and submit it in a later PR (or not). |
mgilson
changed the title
| @@ -443,6 +443,22 @@ describe('util', function() { | |||
| flush(function(){ expect( callBackUsed ).toBeUndefined(); }); | |||
| })); | |||
|
|
|||
| it('should only skip callbacks of scopes which were destroyed', inject(function($mdUtil) { | |||
| var callBackUsed1, callback1 = function(){ callBackUsed1 = true}; | |||
There was a problem hiding this comment.
FWIW, I like the way the callbacks are tracked via a jasmine spy (see line 232), but I used the same idiom used in the previous test since these tests are related. I'm happy to update both tests to use the spy idiom if you'd like.
* Moved `nextTick` tests all into the `describe('nextTick', ...` block
* Minor whitespace changes for consistency with what I've seen in the rest of the project
* used jasmine spys for call tracking since it is cleaner
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
nextTickwould decide whether to run the functions basedon the first
scopeargument passed during a given digest cycle. Thiscould fail in multiple scenarios ...
nextTickcall didn't supply a scope, but subsequent calls did.This could lead to callbacks being executed when they shouldn't be (if
the first scope registered wasn't $$destroyed, this this scope was),
or callbacks not being executed when they should be (the first scope was
$$destroyed, but this scope wasn't).
I believe that this fixes #8358