fix(cli): Make unknown flag check a warning instead of an error. (#4028)

angular · Jan 27, 2017 · 7481dee · 7481dee
1 parent 588901c
commit 7481dee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/lib/runner.ts b/lib/runner.ts
@@ -93,10 +93,11 @@ export class Runner extends EventEmitter {
       unknownFlags = unknownFlags.filter((f) => extraFlags.indexOf(f) === -1);
     }
     if (unknownFlags.length > 0 && !this.config_.disableChecks) {
-      throw new ConfigError(
-          logger,
-          'Found extra flags: ' + unknownFlags.join(', ') +
-              ', please use --disableChecks flag to disable the Protractor CLI flag checks. ');
+      // TODO: Make this throw a ConfigError in Protractor 6.
+      logger.warn(
+          'Ignoring unknown extra flags: ' + unknownFlags.join(', ') + '. This will be' +
+          ' an error in future versions, please use --disableChecks flag to disable the ' +
+          ' Protractor CLI flag checks. ');
     }
     return this.plugins_.onPrepare().then(() => {
       return helper.runFilenameOrFn_(this.config_.configDir, this.preparer_);

diff --git a/scripts/errorTest.js b/scripts/errorTest.js
@@ -19,12 +19,6 @@ var checkLogs = function(output, messages) {
  *Below are exit failure tests*
  ******************************/
 
-runProtractor = spawn('node',
-    ['bin/protractor', 'example/conf.js', '--foobar', 'foobar']);
-output = runProtractor.stdout.toString();
-messages = ['Error: Found extra flags: foobar'];
-checkLogs(output, messages);
-
 // assert authentication error for sauce labs
 runProtractor = spawn('node',
     ['bin/protractor', 'spec/errorTest/sauceLabsAuthentication.js']);