fix(ElementFinder): ElementFinder should allow null as success handler.

Passes the value to the next in the chain.
angular · Oct 1, 2014 · 9db5327 · 9db5327
1 parent 2fbaf52
commit 9db5327
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/protractor.js b/lib/protractor.js
@@ -762,6 +762,9 @@ var buildElementHelper = function(ptor) {
    */
   ElementFinder.prototype.then = function(fn, errorFn) {
     return this.elementArrayFinder_.then(function(actionResults) {
+      if (!fn) {
+        return actionResults[0];
+      }
       return fn(actionResults[0]);
     }, errorFn);
   };

diff --git a/spec/basic/elements_spec.js b/spec/basic/elements_spec.js
@@ -185,6 +185,19 @@ describe('ElementFinder', function() {
       expect(finalResult.getText()).toEqual('Hiya');
     });
   });
+
+  it('should allow null as success handler', function() {
+    browser.get('index.html#/form');
+
+    var usernameInput = element(by.model('username'));
+    var name = element(by.binding('username'));
+
+    expect(name.getText()).toEqual('Anon');
+    expect(
+      name.getText().then(null, function(){})
+    ).toEqual('Anon');
+
+  });
 });
 
 describe('ElementArrayFinder', function() {