Changed Neo4jClient to read login parameters from a file #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 17, 2019 21:31
aniketnk
reviewed
Jun 18, 2019
| @@ -36,13 +36,13 @@ | |||
|
|
|||
| public class Neo4jClient extends DB { | |||
| private static final String URL_PROPERTY = "neo4j.url"; | |||
| private static final String URL_PROPERTY_DEFAULT = "bolt://localhost:7687"; | |||
| private static String URL_PROPERTY_DEFAULT = ""; | |||
|
|
|||
There was a problem hiding this comment.
Let this be as is, because that would be the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4jClient now reads login properties from file db.properties
Create this file in the same directory as the Neo4jClient
the structure should look something like:
URL_PROPERTY_DEFAULT = bolt://localhost:7687
USER_PROPERTY_DEFAULT = neo4j
PASSWORD_PROPERTY_DEFAULT = 1234
Enter the values of these properties as per the your connection and database