Allow role-based authentication for Athena #447
+35
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdelStrother
force-pushed
the
athena-sts
branch
from
b09a3c9
to
6dba9d8
Compare
|
Anything I can do to help get this merged? |
You can now specify role_arn to assume a role for querying Athena, rather than using the access key & secret directly. STS requires a region, which might not be the same region as the database's region. To try & clean up the distinction I've moved all the Athena credential settings to a new `credentials` sub-hash.
jdelStrother
force-pushed
the
athena-sts
branch
from
06fb9ef
to
efde307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT to something like this?
You can now specify role_arn to assume a role for querying Athena, rather than using the access key & secret directly.
STS tokens expire after 1 hour by default, so I've also wrapped the client calls in aautorefresh_credentialsblock. (Which is a little gross, open to better suggestions)[I've since updated to using Aws::AssumeRoleCredentials, which handles autorefreshing for you]
STS requires you to specify a region, which might not be the same as the database's region. To try & clean up the distinction I've moved all the Athena credential settings to a new
credentialssub-hash, but it should continue to work with people still setting access key & secret at the top level.