-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prefix sidebar items with module name (optional) #219
feat: Prefix sidebar items with module name (optional) #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's Amazing! Thanks for creating your first PR for clean-jsdoc-theme. Someone will review it soon!
151f254
to
aaeacbc
Compare
I tried to sign the commits because I had the ssh keys bad configured and had to force push, but apparently I haven't fixed it :( |
1a66c75
to
470794b
Compare
Signed-off-by: javalsai <jvssxxi@gmail.com>
Signed-off-by: javalsai <jvssxxi@gmail.com>
470794b
to
42cb96a
Compare
Also I would like to know if you would be interested in syncing the theme (and font too) between tabs like in the video below. I can try to implement it easily this weekend. theme-sync.mp4 |
About this PR, I will try to test it as soon as possible, probably over the weekends.
Totally. Feel free to suggest as many improvements/ideas as you can. |
I figured out how to include and build the code faster than I expected and already finished the tabs syncing feature, opened a PR #220 for it based off the changes on this one. I don't think that needs documentation, but people can take advantage of it and integrate the syncing with their own website, like I do, if the generated docs are included in it, I leave it up to you. |
@javalsai Could you please add a test |
just did it |
Pull Request Template
Description
Creates an option (
prefixModuleToSidebarItems_experimental
) to add prefixes to sidebar items with their module name.Resolves #218
Type of change
Please mark options that is/are relevant.
More
I don't know how this would behave with sorting as I have it disabled, so I thin it should be tested before merging.
VSCode automatically removed some extra spaces, I hope you're ok with that.