fix: v4.2.15 breaks building docs #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v4.2.15 we have added a feature to include scripts and styles only in target files. In order to do so we are looping through `this.includeScript` and `this.includeCss`. However we are not checking whether these are defined. So, for users who don't want to include any script/style above mentioned variables are undefined for then, hence cause the build to fail because undefined is not iterable. This PR fixes this issue, as now we are checking whether these variables are defined. fixes: #259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v4.2.15 we have added a feature to include scripts and styles only in target files. In order to do so we are looping through
this.includeScriptandthis.includeCss. However we are not checking whether these are defined.So, for users who don't want to include any script/style above mentioned variables are
undefinedfor them, hence causing the build to fail becauseundefinedis not iterable.This PR fixes this issue, as now we are checking whether these variables are defined.
fixes: #259