Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch events tests (backport #3857) #3861

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 1, 2024

Describe your changes

Partially addresses #3828.

  • Adds unit tests for gas payment with whitelisted, non-native token
  • Adds unit tests for batched txs' events
  • Removes the unused Success event
  • Misc refactor of tx signatures in unit tests

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3857 done by [Mergify](https://mergify.com).

(cherry picked from commit 446e32f)
(cherry picked from commit abaace4)
(cherry picked from commit 9625834)
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (e1983f2) to head (9cf0f07).
Report is 11 commits behind head on 0.44.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           0.44.0    #3861   +/-   ##
=======================================
  Coverage   73.03%   73.04%           
=======================================
  Files         340      340           
  Lines      104816   104782   -34     
=======================================
- Hits        76552    76534   -18     
+ Misses      28264    28248   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 2, 2024
@tzemanovic tzemanovic merged commit 2bd9a60 into 0.44.0 Oct 2, 2024
21 of 22 checks passed
@tzemanovic tzemanovic deleted the mergify/bp/0.44.0/pr-3857 branch October 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants