Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests assertions #3902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Oct 8, 2024

Describe your changes

Updates assert_success in integration tests to avoid ignoring missing results.
Fixes wrong usage of the same function in conjunction with Client commands that don't modify the auxiliary fields of InnerMockNode.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (7ac415a) to head (e2ad712).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3902   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files         341      341           
  Lines      105240   105240           
=======================================
  Hits        77085    77085           
  Misses      28155    28155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review October 8, 2024 20:05
@grarco grarco force-pushed the grarco/fix-integration-tests branch from e2ad712 to 7906be7 Compare October 9, 2024 13:29
@grarco grarco requested a review from sug0 October 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant